If he only uncovered what was illegal (allegedly and not conclusively proven) against American citizens he would have been fine in the case of public opinion but not under law. But what he has done is release information against our operations outside the US. This is well beyond what is done against Americans under Constitutional issues. We've passed that point and dealing with info that harms our intel gathering abilities elsewhere.
If you are about rule of law, he had means of carrying this out using whistleblower protections. If it were purely about rights of Americans being violated he could have just leaked all of this to Rand Paul, Ted Cruz, or some other elected official who could have run with this still within legal means. But now what he has done is gone beyond a legal path and is really no different in breaking the law than those he accuses. Rule of law is rule of law.
The fact he has gone to China and Russia negates his whole freedom and free speech rant. He has traveled to regimes that are everything against what he claims he is for. These two nations are geopolitical enemies no matter how you sugarcoat it. The fact he has dropped Cuba, Venezuela, and Ecuador also bring question to his whole notion about liberties, free speech, etc.
Because he did not bring this through legal means and stayed in country all this does is make this a PR nightmare and cause a few hearings which change nothing. If anything, it drives this type of operation further into the shadows. Contractors are now screened more. Oversight dwindles. The human element begins to be removed because trust is questioned with who handles all of this.
So based on what he did and how he did it, I would drop him into the traitor column and even go as far to call him an idiot as well. Cost benefit, all he did was cause a PR black eye, drive this effort further underground, and now provided information to our enemies as to how we collect and analyze intel - especially the legal means (which is ignored in all of this that legal methods are now known).